[SPARK-46818][SQL] Improve error messages for Range with non-foldable inputs #44857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
force-pushed
the
spark-46818-fix-range
branch
from
a631b67
to
5fa9e24
Compare
MaxGekk
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Yes. Error message improvement.
@allisonwang-db Could you show the output after your changes.
|
@MaxGekk updated the PR description. The test failures do not seem to be related but I've retriggered them. |
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the error messages for the
Rangefunction when the input arguments are not foldable.Why are the changes needed?
To make error messages more user-friendly.
For example, before this PR, Spark throws an internal error:
After this PR, the error message will be:
Does this PR introduce any user-facing change?
Yes. Error message improvement.
How was this patch tested?
New SQL tests.
Was this patch authored or co-authored using generative AI tooling?
No