Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46828][SQL] Remove the invalid assertion of remote mode for spark sql shell #44868

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

It is safe to clean up the read side code in SparkSQLCLIDriver as org.apache.hadoop.hive.ql.session.SessionState.setIsHiveServerQuery is never invoked.

Why are the changes needed?

code refactoring for the purpose of having more upgradable hive deps.

Does this PR introduce any user-facing change?

no

How was this patch tested?

  • build and run bin/spark-sql
Spark Web UI available at http://***:4040
Spark master: local[*], Application Id: local-1706087266338
spark-sql (default)> show tables;
Time taken: 0.327 seconds
spark-sql (default)> show databases;
default
Time taken: 0.161 seconds, Fetched 1 row(s)
  • CliSuite

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Jan 24, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0. Thank you, @yaooqinn .

@yaooqinn yaooqinn deleted the SPARK-46828 branch January 25, 2024 06:22
@yaooqinn
Copy link
Member Author

Thank you very much @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants