[SPARK-46873][SS] Do not recreate new StreamingQueryManager for the same Spark Session #44898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my local env failed to build.. let's wait if CI passes |
HyukjinKwon
reviewed
Jan 26, 2024
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
HyukjinKwon
approved these changes
Jan 26, 2024
|
Hi Hyukjin @HyukjinKwon, I think this is ready to be merged! : ) |
|
Merged to master. |
WweiL
added a commit
to WweiL/oss-spark
that referenced
this pull request
May 2, 2024
…ame Spark Session In Scala, there is only one streaming query manager for one spark session: ``` scala> spark.streams val res0: org.apache.spark.sql.streaming.StreamingQueryManager = org.apache.spark.sql.streaming.StreamingQueryManager46bb8cba scala> spark.streams val res1: org.apache.spark.sql.streaming.StreamingQueryManager = org.apache.spark.sql.streaming.StreamingQueryManager46bb8cba scala> spark.streams val res2: org.apache.spark.sql.streaming.StreamingQueryManager = org.apache.spark.sql.streaming.StreamingQueryManager46bb8cba scala> spark.streams val res3: org.apache.spark.sql.streaming.StreamingQueryManager = org.apache.spark.sql.streaming.StreamingQueryManager46bb8cba ``` In Python, this is currently false for both connect and vanilla spark: ``` >>> spark.streams <pyspark.sql.connect.streaming.query.StreamingQueryManager object at 0x1011f7c10> >>> spark.streams <pyspark.sql.connect.streaming.query.StreamingQueryManager object at 0x1011f71f0> >>> spark.streams <pyspark.sql.connect.streaming.query.StreamingQueryManager object at 0x1011f7be0> >>> spark.streams <pyspark.sql.connect.streaming.query.StreamingQueryManager object at 0x1011f7c40> ``` This PR makes the spark session reuse existing streaming query manager Python should align Scala behavior. No Added unit test No Closes apache#44898 from WweiL/SPARK-46873-sqm-reuse. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Scala, there is only one streaming query manager for one spark session:
In Python, this is currently false for both connect and vanilla spark:
This PR makes the spark session reuse existing streaming query manager
Why are the changes needed?
Python should align Scala behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit test
Was this patch authored or co-authored using generative AI tooling?
No