[SPARK-46911][SS] Adding deleteIfExists operator to StatefulProcessorHandleImpl #44903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...re/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
ericm-db
changed the title
ericm-db
changed the title
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessorHandle.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessorHandle.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
Show resolved
Hide resolved
ericm-db
force-pushed
the
deleteIfExists
branch
from
f5e41a1
to
d63aeee
Compare
ericm-db
force-pushed
the
deleteIfExists
branch
2 times, most recently
from
80696e2
to
db52b3d
Compare
sql/api/src/main/scala/org/apache/spark/sql/streaming/StatefulProcessorHandle.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
anishshri-db
approved these changes
Jan 31, 2024
|
cc @HeartSaVioR |
HeartSaVioR
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Only nits. I haven't looked into the test change in detail and I may probably revisit the code, but I can sign off without revisiting as @anishshri-db reviewed that part already.
...main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
reviewed
Feb 1, 2024
| @transient private var _countState: ValueState[Long] = _ | ||
| @transient private var _mostRecent: ValueState[String] = _ | ||
| @transient var _processorHandle: StatefulProcessorHandle = _ | ||
|
|
||
| override def init( | ||
| handle: StatefulProcessorHandle, | ||
| outputMode: OutputMode) : Unit = { | ||
| handle: StatefulProcessorHandle, |
There was a problem hiding this comment.
nit: 4 spaces for method params. https://github.com/databricks/scala-style-guide?tab=readme-ov-file#indent
ericm-db
force-pushed
the
deleteIfExists
branch
from
4f38d57
to
0f2bd41
Compare
|
cc @HeartSaVioR, addressed all comments |
anishshri-db
reviewed
Feb 1, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreErrors.scala
Outdated
Show resolved
Hide resolved
|
GA failure is only from docker integration test which is unrelated. |
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding the
deleteIfExistsmethod to theStatefulProcessorHandlein order to remove state variables from the State Store. Implemented only for RocksDBStateStoreProvider, as we do not currently support multiple column families for HDFS.Why are the changes needed?
This functionality is needed to so users can remove state from the state store from the StatefulProcessorHandleImpl
Does this PR introduce any user-facing change?
Yes - this functionality (removing column families) was previously not supported from our RocksDB client.
How was this patch tested?
Added a unit test that creates two streams with the same checkpoint directory. The second stream removes state that was created in the first stream upon initialization. We ensure that the state from the previous stream isn't kept.
Was this patch authored or co-authored using generative AI tooling?