[SPARK-46885][SQL] Push down filters through TypedFilter
#44911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
reviewed
Jan 29, 2024
| @@ -1836,6 +1836,7 @@ object PushPredicateThroughNonJoin extends Rule[LogicalPlan] with PredicateHelpe | |||
| case _: BatchEvalPython => true | |||
| case _: ArrowEvalPython => true | |||
| case _: Expand => true | |||
| case _: TypedFilter => true | |||
There was a problem hiding this comment.
hmm, what if the filter lambda function is non-deterministic?
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enhances
PushPredicateThroughNonJointo make it support pushing down filters throughTypedFilter.Why are the changes needed?
Pushed filters can be pushed down to file scanning to improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test,
Was this patch authored or co-authored using generative AI tooling?
No.