[SPARK-46987][CONNECT] ProtoUtils.abbreviate avoid unnecessary setField operation
#45045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Although this PR looks safe, could you re-trigger the failed pipeline because it's connect -related module, @zhengruifeng ?
ERROR [38.613s]: test_crossvalidator_with_fold_col (pyspark.ml.tests.connect.test_connect_tuning.CrossValidatorTestsOnConnect)
|
LGTM once tests passed, thanks! |
|
All test passed. Merged into master for Spark 4.0. Thanks @zhengruifeng @dongjoon-hyun @xinrong-meng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ProtoUtils.abbreviateavoid unnecessarysetFieldoperationWhy are the changes needed?
according to the API reference:
the builder we used already has all the fields, so we only need to update the truncated fields.
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no