[SPARK-46994][PYTHON] Refactor PythonWrite to prepare for supporting python data source streaming write #45049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoqin-li1123
changed the title
|
@HyukjinKwon @HeartSaVioR @allisonwang-db PTAL, thanks! |
|
Would you create a Spark JIRA https://issues.apache.org/jira/browse/SPARK and add it to the PR title? Please refer to https://spark.apache.org/contributing.html for details. Thanks! |
allisonwang-db
approved these changes
Feb 6, 2024
chaoqin-li1123
changed the title
HeartSaVioR
changed the title
HeartSaVioR
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
+1
Let me hold this a day to see the chance @HyukjinKwon can review. Will merge if there is no further comment by today.
|
Thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move PythonBatchWrite out of PythonWrite.
Why are the changes needed?
This is to prepare for supporting python data source streaming write in the future.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Trivial code refactoring, existing test sufficient.
Was this patch authored or co-authored using generative AI tooling?
No.