Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47004][CONNECT] Added more tests to ClientStreamingQuerySuite to increase Scala client test coverage #45063

Closed
wants to merge 3 commits into from

Conversation

bogao007
Copy link
Contributor

@bogao007 bogao007 commented Feb 7, 2024

What changes were proposed in this pull request?

Added more tests to ClientStreamingQuerySuite to increase Scala client test coverage

  • Included AvailableNow trigger, processingTime trigger and default trigger have been covered by existing tests.
  • Added file tests with read/save options, including 2 new test resources for csv and text file sources.
  • Added test for streaming temp view.

Why are the changes needed?

To increase test coverage for Streaming Spark Connect Scala client

Does this PR introduce any user-facing change?

No

How was this patch tested?

This is a test-only change.

Was this patch authored or co-authored using generative AI tooling?

No

Copy link
Contributor

@rangadi rangadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more tests.

@bogao007 bogao007 changed the title [SPARK-47004] Added more tests to ClientStreamingQuerySuite to increase Scala client test coverage [SPARK-47004][CONNECT] Added more tests to ClientStreamingQuerySuite to increase Scala client test coverage Feb 9, 2024
@bogao007
Copy link
Contributor Author

bogao007 commented Feb 9, 2024

Hi @HyukjinKwon, could you help review this PR and merge if it looks good to you? Thanks!

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants