Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47030][TESTS] Add WebBrowserTest #45089

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 12, 2024

What changes were proposed in this pull request?

This PR aims to add a new test tag, WebBrowserTest.

Why are the changes needed?

Currently, several browser-based tests exist in multiple modules like the following. It's difficult to find and run them.

common/tags/src/test/java/org/apache/spark/tags/WebBrowserTest.java
core/src/test/scala/org/apache/spark/deploy/history/ChromeUIHistoryServerSuite.scala
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
core/src/test/scala/org/apache/spark/ui/ChromeUISeleniumSuite.scala
core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala
sql/core/src/test/scala/org/apache/spark/sql/streaming/ui/UISeleniumSuite.scala
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala

In addition, the previous ChromeUITest is designed to disable ChromeUI* suite and doesn't cover all WebBroser based test suite.

Does this PR introduce any user-facing change?

No, this is a new test tag.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon and @LuciferYang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants