[SPARK-47052][SS] Separate state tracking variables from MicroBatchExecution/StreamExecution #45109
+945
−470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
changed the title
HeartSaVioR
reviewed
Feb 20, 2024
| currentStatus = currentStatus.copy(message = message) | ||
| /** Extracts observed metrics from the most recent query execution. */ | ||
| private def extractObservedMetrics( | ||
| lastExecution: QueryExecution): Map[String, Row] = { |
| val timeTaken = math.max(endTime - startTime, 0) | ||
| /** Extracts statistics from the most recent query execution. */ | ||
| private def extractExecutionStats( | ||
| hasNewData: Boolean, |
| return Map.empty | ||
| /** Extract statistics about stateful operators from the executed query plan. */ | ||
| private def extractStateOperatorMetrics( | ||
| lastExecution: IncrementalExecution): Seq[StateOperatorProgress] = { |
| if (!hasNewData) { | ||
| return ExecutionStats(Map.empty, stateOperators, watermarkTimestamp) | ||
| private def warnIfFinishTriggerTakesTooLong( | ||
| triggerEndTimestamp: Long, |
| * Override of finishTrigger to extract the map from IncrementalExecution. | ||
| */ | ||
| def finishTrigger( | ||
| hasNewData: Boolean, |
| to: StreamProgress, | ||
| latest: StreamProgress): Unit = { | ||
| def recordTriggerOffsets( | ||
| from: StreamProgress, |
| * during the execution lifecycle of a batch that is being processed by the streaming query | ||
| */ | ||
| abstract class ProgressContext( | ||
| id: UUID, |
| } | ||
|
|
||
| def updateIdleness( | ||
| id: UUID, |
| private def getStartOffset(dataStream: SparkDataStream): OffsetV2 = { | ||
| val startOffsetOpt = availableOffsets.get(dataStream) | ||
| private def getStartOffset( | ||
| execCtx: MicroBatchExecutionContext, |
| private def populateStartOffsets(sparkSessionToRunBatches: SparkSession): Unit = { | ||
| sinkCommitProgress = None | ||
| protected def populateStartOffsets( | ||
| execCtx: MicroBatchExecutionContext, |
HeartSaVioR
changed the title
|
Could you please rebase the master branch of your fork with the latest in OSS repo, and rebase your PR against the latest master as well? It may resolve issues the CI shows us as failure in linter. |
…ion/StreamExecution
jerrypeng
force-pushed
the
SPARK-47052
branch
from
0e3b8ab
to
45ae190
Compare
|
@HeartSaVioR thanks for your review! I have addressed your comments. PTAL! |
|
The CI only failed from pyspark-connect and failures look to be unrelated (not related to streaming). |
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To improve code clarity and maintainability, I propose that we move all the variables that track mutable state and metrics for a streaming query into a separate class. With this refactor, it would be easy to track and find all the mutable state a microbatch can have.
Why are the changes needed?
To improve code clarity and maintainability. All the state and metrics that is needed for the execution lifecycle of a microbatch is consolidated into one class. If we decide to modify or add additional state to a streaming query, it will be easier to determine 1) where to add it 2) what existing state are there.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should suffice
Was this patch authored or co-authored using generative AI tooling?
No