[SPARK-47055][PYTHON] Upgrade MyPy 1.8.0 #45115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
SQL
ML
STRUCTURED STREAMING
BUILD
CORE
INFRA
PYTHON
DSTREAM
PANDAS API ON SPARK
CONNECT
labels
HyukjinKwon
force-pushed
the
SPARK-47055
branch
3 times, most recently
from
3ebe195
to
35e4d0d
Compare
HyukjinKwon
force-pushed
the
SPARK-47055
branch
from
35e4d0d
to
4be729d
Compare
|
Ah .. I need to fix MyPy data tests too.. I will turn this to a draft for now. |
HyukjinKwon
force-pushed
the
SPARK-47055
branch
from
4be729d
to
e6c5df5
Compare
HyukjinKwon
commented
Feb 15, 2024
| if [[ "$MYPY_DATA_TEST" == "true" ]]; then | ||
| mypy_data_test | ||
| fi | ||
| # TODO(SPARK-47057): Reeanble MyPy data test |
There was a problem hiding this comment.
I will enable this in a separate PR once this PR is merged.
|
Python linter seems to complain still. |
|
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 16, 2024
…n 3.12 support ### What changes were proposed in this pull request? This PR unpins the version for torch in our CI. This PR is dependent on #45115 ### Why are the changes needed? Testing latest version. This also blocks SPARK-46078. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested via `./dev/lint-python`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45113 from HyukjinKwon/SPARK-47054. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
HyukjinKwon
added a commit
that referenced
this pull request
Feb 17, 2024
### What changes were proposed in this pull request? This is a followup of #45115 that enables MyPy data test. ### Why are the changes needed? To reenable MyPy data test. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the test via `./dev/lint-python`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45135 from HyukjinKwon/SPARK-47057. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes upgrade MyPy to 1.8.0.
Why are the changes needed?
To unblock the full support of Python 3.12 with CI. This unblocks #45113
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually ran
dev/line-pythonWas this patch authored or co-authored using generative AI tooling?
No.