[SPARK-5732][CORE]:Add an option to print the spark version in spark script. #4522
Conversation
|
Test build #27274 has started for PR 4522 at commit
|
|
Test build #27274 has finished for PR 4522 at commit
|
|
Test FAILed. |
|
An irrelevant test failure in |
| verbose = true | ||
| parse(tail) | ||
|
|
||
| case ("--version" | "-v") :: tail => |
There was a problem hiding this comment.
Eh, I don't think you should just change behavior of -v!
There was a problem hiding this comment.
Yes, it remains open to question.
There was a problem hiding this comment.
IMHO it would be better to keep the compatible behavior to the old version, not to change -v.
There was a problem hiding this comment.
OK, I will remain the behavior of -v
|
Yeah we cannot change the behavior of |
|
LGTM if the behavior of |
|
Test build #27420 has started for PR 4522 at commit
|
|
Test build #27420 has finished for PR 4522 at commit
|
|
Test PASSed. |
| @@ -89,6 +90,17 @@ object SparkSubmit { | |||
| printStream.println("Run with --help for usage help or --verbose for debug output") | |||
| exitFn() | |||
| } | |||
| private[spark] def printVersionAndExit() = { | |||
|
Merged into master and 1.3 after fixing the comments myself. I realize that the neighboring functions also do not have the correct return type so I added those too. Thanks @uncleGen |
…script. Naturally, we may need to add an option to print the spark version in spark script. It is pretty common in script tool.  Author: uncleGen <hustyugm@gmail.com> Author: genmao.ygm <genmao.ygm@alibaba-inc.com> Closes #4522 from uncleGen/master-clean-150211 and squashes the following commits: 9f2127c [genmao.ygm] revert the behavior of "-v" 015ddee [uncleGen] minor changes 463f02c [uncleGen] minor changes (cherry picked from commit c0ccd25) Signed-off-by: Andrew Or <andrew@databricks.com>
…a 2.11 This PR removes most of the code in the Spark REPL for Scala 2.11 and leaves just a couple of overridden methods in `SparkILoop` in order to: - change welcome message - restrict available commands (like `:power`) - initialize Spark context The two codebases have diverged and it's extremely hard to backport fixes from the upstream REPL. This somewhat radical step is absolutely necessary in order to fix other REPL tickets (like SPARK-8013 - Hive Thrift server for 2.11). BTW, the Scala REPL has fixed the serialization-unfriendly wrappers thanks to ScrapCodes's work in [#4522](scala/scala#4522) All tests pass and I tried the `spark-shell` on our Mesos cluster with some simple jobs (including with additional jars), everything looked good. As soon as Scala 2.11.7 is out we need to upgrade and get a shaded `jline` dependency, clearing the way for SPARK-8013. /cc pwendell Author: Iulian Dragos <jaguarul@gmail.com> Closes #6903 from dragos/issue/no-spark-repl-fork and squashes the following commits: c596c6f [Iulian Dragos] Merge branch 'master' into issue/no-spark-repl-fork 2b1a305 [Iulian Dragos] Removed spaces around multiple imports. 0ce67a6 [Iulian Dragos] Remove -verbose flag for java compiler (added by mistake in an earlier commit). 10edaf9 [Iulian Dragos] Keep the jline dependency only in the 2.10 build. 529293b [Iulian Dragos] Add back Spark REPL files to rat-excludes, since they are part of the 2.10 real. d85370d [Iulian Dragos] Remove jline dependency from the Spark REPL. b541930 [Iulian Dragos] Merge branch 'master' into issue/no-spark-repl-fork 2b15962 [Iulian Dragos] Change jline dependency and bump Scala version. b300183 [Iulian Dragos] Rename package and add license on top of the file, remove files from rat-excludes and removed `-Yrepl-sync` per reviewer’s request. 9d46d85 [Iulian Dragos] Fix SPARK-7944. abcc7cb [Iulian Dragos] Remove the REPL forked code.
Naturally, we may need to add an option to print the spark version in spark script. It is pretty common in script tool.
