[SPARK-47157][SQL] Refactor file listing with ScanFileListing interface #45224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtenedor
approved these changes
Feb 23, 2024
|
@HyukjinKwon @cloud-fan if this change looks good to you, would one of you mind to help merge it? 🙏 |
|
Seems fine but mind filing a JIRA and put it into the PR title? See also https://spark.apache.org/contributing.html |
HyukjinKwon
approved these changes
Feb 25, 2024
costas-db
changed the title
|
Merged to master. |
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Feb 26, 2024
### What changes were proposed in this pull request? In this pull request, we've introduce the `ScanFileListing` trait and its implementation, the `GenericScanFileListing` class, to encapsulate and streamline the handling of file listing results. This new abstraction enhances modularity and facilitates more flexible management of file listings within the system. ### Why are the changes needed? The introduction of these constructs is crucial for defining a standardized API for file listing operations, regardless of the underlying representation that's used to represent files and partitions. By improving the modularity of the code we enable future improvements that can prove to be beneficial both for runtime and memory improvements. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is just a refactoring, not a new behavior, so existing tests would suffice. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45224 from costas-db/refactorFileListing. Lead-authored-by: Costas Zarifis <costas.zarifis@databricks.com> Co-authored-by: Shoumik Palkar <shoumik.palkar@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? In this pull request, we've introduce the `ScanFileListing` trait and its implementation, the `GenericScanFileListing` class, to encapsulate and streamline the handling of file listing results. This new abstraction enhances modularity and facilitates more flexible management of file listings within the system. ### Why are the changes needed? The introduction of these constructs is crucial for defining a standardized API for file listing operations, regardless of the underlying representation that's used to represent files and partitions. By improving the modularity of the code we enable future improvements that can prove to be beneficial both for runtime and memory improvements. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is just a refactoring, not a new behavior, so existing tests would suffice. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45224 from costas-db/refactorFileListing. Lead-authored-by: Costas Zarifis <costas.zarifis@databricks.com> Co-authored-by: Shoumik Palkar <shoumik.palkar@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this pull request, we've introduce the
ScanFileListingtrait and its implementation, theGenericScanFileListingclass, to encapsulate and streamline the handling of file listing results. This new abstraction enhances modularity and facilitates more flexible management of file listings within the system.Why are the changes needed?
The introduction of these constructs is crucial for defining a standardized API for file listing operations, regardless of the underlying representation that's used to represent files and partitions. By improving the modularity of the code we enable future improvements that can prove to be beneficial both for runtime and memory improvements.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is just a refactoring, not a new behavior, so existing tests would suffice.
Was this patch authored or co-authored using generative AI tooling?
No