[SPARK-47158][SQL] Assign proper name and sqlState to _LEGACY_ERROR_TEMP_(2134|2231)
#45244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
changed the title
sqlState to _LEGACY_ERROR_TEMP_(2134|2231)sqlState to _LEGACY_ERROR_TEMP_(2134|2231)
|
@MaxGekk Could you review this when you find some time? They are currently the most frequent top 2 legacy error classes. |
|
@itholic Thanks for the ping. I will look at it soon. |
MaxGekk
requested changes
Feb 26, 2024
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala
Show resolved
Hide resolved
|
Thanks, @MaxGekk for the review! Just adjusted comments |
MaxGekk
requested changes
Feb 28, 2024
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Feb 29, 2024
sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala
Outdated
Show resolved
Hide resolved
|
Updated PR description and fixed the test. |
|
Oh, actually they are related. Let me fix it. |
MaxGekk
requested changes
Mar 1, 2024
There was a problem hiding this comment.
@itholic Could you fix the failed test:
[info] RowSuite:
...
[info] - SPARK-37654: row contains a null at the requested index should return null (1 millisecond)
[info] - access fieldIndex on Row without schema *** FAILED *** (4 milliseconds)
[info] Map("methodName" -> "fieldIndex", "className" -> "Row", "fieldName" -> "`foo`") did not equal Map("methodName" -> "fieldIndex", "className" -> "Row", "fieldName" -> "foo") (SparkFunSuite.scala:362)
MaxGekk
approved these changes
Mar 1, 2024
|
+1, LGTM. Merging to master. |
|
Thanks for the review, @MaxGekk ! |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…R_TEMP_(2134|2231)` ### What changes were proposed in this pull request? This PR proposes to assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` - `_LEGACY_ERROR_TEMP_2134` -> `CANNOT_PARSE_STRING_AS_DATATYPE` - `_LEGACY_ERROR_TEMP_2231` -> `UNSUPPORTED_CALL.FIELD_INDEX` ### Why are the changes needed? To improve error usability ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error message will be improved ### How was this patch tested? Added UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45244 from itholic/TOP_LEGACY_ERRORS. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…R_TEMP_(2134|2231)` ### What changes were proposed in this pull request? This PR proposes to assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` - `_LEGACY_ERROR_TEMP_2134` -> `CANNOT_PARSE_STRING_AS_DATATYPE` - `_LEGACY_ERROR_TEMP_2231` -> `UNSUPPORTED_CALL.FIELD_INDEX` ### Why are the changes needed? To improve error usability ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error message will be improved ### How was this patch tested? Added UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45244 from itholic/TOP_LEGACY_ERRORS. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
…R_TEMP_(2134|2231)` ### What changes were proposed in this pull request? This PR proposes to assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` - `_LEGACY_ERROR_TEMP_2134` -> `CANNOT_PARSE_STRING_AS_DATATYPE` - `_LEGACY_ERROR_TEMP_2231` -> `UNSUPPORTED_CALL.FIELD_INDEX` ### Why are the changes needed? To improve error usability ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error message will be improved ### How was this patch tested? Added UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45244 from itholic/TOP_LEGACY_ERRORS. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign proper name and
sqlStateto_LEGACY_ERROR_TEMP_(2134|2231)_LEGACY_ERROR_TEMP_2134->CANNOT_PARSE_STRING_AS_DATATYPE_LEGACY_ERROR_TEMP_2231->UNSUPPORTED_CALL.FIELD_INDEXWhy are the changes needed?
To improve error usability
Does this PR introduce any user-facing change?
No API changes, but the user-facing error message will be improved
How was this patch tested?
Added UTs.
Was this patch authored or co-authored using generative AI tooling?
No.