[SPARK-47175][SS][TESTS] Remove ZOOKEEPER-1844 comment from KafkaTestUtils
#45265
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-47175
branch
from
387cd04
to
8c3404b
Compare
HyukjinKwon
approved these changes
Feb 26, 2024
|
Thanks @dongjoon-hyun @HyukjinKwon, merged to master |
|
Thank you, @HyukjinKwon and @yaooqinn ! |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…tUtils` ### What changes were proposed in this pull request? This PR aims to remove [ZOOKEEPER-1844](https://issues.apache.org/jira/browse/ZOOKEEPER-1844) comment from `KafkaTestUtils`. ### Why are the changes needed? Apache Spark has been using Apache Zookeeper 3.4.6+ already since `Apache Spark 2.2.0` via SPARK-19464. We don't need to remove the code itself. This PR simply aims to remove the resolved pointers. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This is a removal of comment. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45265 from dongjoon-hyun/SPARK-47175. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Kent Yao <yao@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…tUtils` ### What changes were proposed in this pull request? This PR aims to remove [ZOOKEEPER-1844](https://issues.apache.org/jira/browse/ZOOKEEPER-1844) comment from `KafkaTestUtils`. ### Why are the changes needed? Apache Spark has been using Apache Zookeeper 3.4.6+ already since `Apache Spark 2.2.0` via SPARK-19464. We don't need to remove the code itself. This PR simply aims to remove the resolved pointers. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This is a removal of comment. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45265 from dongjoon-hyun/SPARK-47175. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove ZOOKEEPER-1844 comment from
KafkaTestUtils.Why are the changes needed?
Apache Spark has been using Apache Zookeeper 3.4.6+ already since
Apache Spark 2.2.0via SPARK-19464.We don't need to remove the code itself. This PR simply aims to remove the resolved pointers.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a removal of comment.
Was this patch authored or co-authored using generative AI tooling?
No.