[SPARK-47184][PYTHON][CONNECT][TESTS] Make test_repartitionByRange_dataframe reusable
#45281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Feb 27, 2024
| self.assertEqual(df3.rdd.first(), df2.rdd.first()) | ||
| self.assertEqual(df3.rdd.take(3), df2.rdd.take(3)) | ||
|
|
||
| self.assertEqual(df3.select(spark_partition_id()).distinct().count(), 2) |
There was a problem hiding this comment.
df.select(spark_partition_id()).distinct().count() is not always equivalent to df.rdd. getNumPartitions() (e.g. empty partitions, AQE rules), but in this UT they are the same
HyukjinKwon
approved these changes
Feb 27, 2024
|
merged to master |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…ataframe` reusable ### What changes were proposed in this pull request? Make `test_repartitionByRange_dataframe` reusable ### Why are the changes needed? to make it reusable in Spark Connect ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? updated ut ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45281 from zhengruifeng/connect_test_repartitionByRange_dataframe. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…ataframe` reusable ### What changes were proposed in this pull request? Make `test_repartitionByRange_dataframe` reusable ### Why are the changes needed? to make it reusable in Spark Connect ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? updated ut ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45281 from zhengruifeng/connect_test_repartitionByRange_dataframe. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
test_repartitionByRange_dataframereusableWhy are the changes needed?
to make it reusable in Spark Connect
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
updated ut
Was this patch authored or co-authored using generative AI tooling?
no