[SPARK-47202][PYTHON] Fix typo breaking datetimes with tzinfo #45301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhengruifeng @ueshin could you please review this? |
|
Hi, @arzavj Can you enable the GHA? https://github.com/apache/spark/pull/45301/checks?check_run_id=22059858407 |
|
I did enable it after it failed but I don't know how to re-run the check |
|
Try |
yaooqinn
approved these changes
Feb 28, 2024
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Feb 28, 2024
HyukjinKwon
reviewed
Feb 28, 2024
| @@ -993,7 +993,7 @@ def convert_struct(value: Any) -> Any: | |||
|
|
|||
| def convert_timestamp(value: Any) -> Any: | |||
| if isinstance(value, datetime.datetime) and value.tzinfo is not None: | |||
| ts = pd.Timstamp(value) | |||
| ts = pd.Timestamp(value) | |||
There was a problem hiding this comment.
I am fine as is because it's pretty obvious but would be good to have a test at python/pyspark/sql/tests/test_arrow.py.
There was a problem hiding this comment.
+1 for the above comment about adding a test coverage.
There was a problem hiding this comment.
Yeah I considered adding a test for this but really what we need here is a linter in CI to catch such typos
dongjoon-hyun
approved these changes
Feb 28, 2024
|
Let me just merge this in and follow up with a test. |
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 28, 2024
This PR fixes a bug caused due to a typo. This bug is preventing users from having datetime.datetime objects with tzinfo when using the `TimestampType` No, just a bug fix. There ought to be CI that lints code and catches these simple errors at the time of opening the PR. No Closes #45301 from arzavj/SPARK-47202. Authored-by: Arzav Jain <arzavj@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit bf8396e) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
PTAL: #45308 |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 28, 2024
… toPandas and createDataFrame with Arrow optimized ### What changes were proposed in this pull request? This PR is a follow up of #45301 that actually test the change. ### Why are the changes needed? To prevent a regression. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45308 from HyukjinKwon/SPARK-47202-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Feb 28, 2024
… toPandas and createDataFrame with Arrow optimized ### What changes were proposed in this pull request? This PR is a follow up of #45301 that actually test the change. ### Why are the changes needed? To prevent a regression. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45308 from HyukjinKwon/SPARK-47202-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 721c2a4) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
### What changes were proposed in this pull request? This PR fixes a bug caused due to a typo. ### Why are the changes needed? This bug is preventing users from having datetime.datetime objects with tzinfo when using the `TimestampType` ### Does this PR introduce _any_ user-facing change? No, just a bug fix. ### How was this patch tested? There ought to be CI that lints code and catches these simple errors at the time of opening the PR. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45301 from arzavj/SPARK-47202. Authored-by: Arzav Jain <arzavj@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
… toPandas and createDataFrame with Arrow optimized ### What changes were proposed in this pull request? This PR is a follow up of apache#45301 that actually test the change. ### Why are the changes needed? To prevent a regression. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45308 from HyukjinKwon/SPARK-47202-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
@HyukjinKwon do you know when I can expect 3.5.2 to be released to be able to take advantage of this bug fix? |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? This PR fixes a bug caused due to a typo. ### Why are the changes needed? This bug is preventing users from having datetime.datetime objects with tzinfo when using the `TimestampType` ### Does this PR introduce _any_ user-facing change? No, just a bug fix. ### How was this patch tested? There ought to be CI that lints code and catches these simple errors at the time of opening the PR. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45301 from arzavj/SPARK-47202. Authored-by: Arzav Jain <arzavj@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
… toPandas and createDataFrame with Arrow optimized ### What changes were proposed in this pull request? This PR is a follow up of apache#45301 that actually test the change. ### Why are the changes needed? To prevent a regression. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45308 from HyukjinKwon/SPARK-47202-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a bug caused due to a typo.
Why are the changes needed?
This bug is preventing users from having datetime.datetime objects with tzinfo when using the
TimestampTypeDoes this PR introduce any user-facing change?
No, just a bug fix.
How was this patch tested?
There ought to be CI that lints code and catches these simple errors at the time of opening the PR.
Was this patch authored or co-authored using generative AI tooling?
No