-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][DOCS] Remove extraneous whitespace from SQL tuning page #45318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchammas It would be nice for such kind of changes to add a screenshot to PR description.
I usually do (e.g. see #44955), but in this case the rendered output is unchanged. Nonetheless, I've added a screenshot. |
MaxGekk
approved these changes
Feb 28, 2024
HyukjinKwon
approved these changes
Feb 29, 2024
Merged to master. |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
### What changes were proposed in this pull request? - Remove extraneous whitespace. - Change Liquid formatting block into "normal" Markdown code block. ### Why are the changes needed? Minor documentation cleanup. ### Does this PR introduce _any_ user-facing change? No. Here is the rendered output, which is unchanged. <img width="500" alt="Screenshot 2024-02-28 at 2 12 25 PM" src="https://github.com/apache/spark/assets/1039369/ae6fcc1c-b0fe-496b-87d0-a6c44c597c0e"> ### How was this patch tested? I built and reviewed the docs locally. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45318 from nchammas/sql-tuning-whitespace. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? - Remove extraneous whitespace. - Change Liquid formatting block into "normal" Markdown code block. ### Why are the changes needed? Minor documentation cleanup. ### Does this PR introduce _any_ user-facing change? No. Here is the rendered output, which is unchanged. <img width="500" alt="Screenshot 2024-02-28 at 2 12 25 PM" src="https://github.com/apache/spark/assets/1039369/ae6fcc1c-b0fe-496b-87d0-a6c44c597c0e"> ### How was this patch tested? I built and reviewed the docs locally. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45318 from nchammas/sql-tuning-whitespace. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
### What changes were proposed in this pull request? - Remove extraneous whitespace. - Change Liquid formatting block into "normal" Markdown code block. ### Why are the changes needed? Minor documentation cleanup. ### Does this PR introduce _any_ user-facing change? No. Here is the rendered output, which is unchanged. <img width="500" alt="Screenshot 2024-02-28 at 2 12 25 PM" src="https://github.com/apache/spark/assets/1039369/ae6fcc1c-b0fe-496b-87d0-a6c44c597c0e"> ### How was this patch tested? I built and reviewed the docs locally. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45318 from nchammas/sql-tuning-whitespace. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Minor documentation cleanup.
Does this PR introduce any user-facing change?
No. Here is the rendered output, which is unchanged.
How was this patch tested?
I built and reviewed the docs locally.
Was this patch authored or co-authored using generative AI tooling?
No.