[SPARK-46961][SS] Using ProcessorContext to store and retrieve handle #45359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
reviewed
Mar 1, 2024
| @@ -53,6 +53,12 @@ private[sql] trait ExecutionErrors extends DataTypeErrorsBase { | |||
| e) | |||
| } | |||
|
|
|||
| def stateStoreHandleNotInitialized(): SparkRuntimeException = { | |||
There was a problem hiding this comment.
Can we move this to the StateStoreErrors.scala to keep error classes in this area in a common location ?
There was a problem hiding this comment.
@ericm-db Could you move it, please.
There was a problem hiding this comment.
@MaxGekk we can't move it to StateStoreErrors.scala because we can't use it in sql/api/ where we throw the error
anishshri-db
reviewed
Mar 1, 2024
anishshri-db
approved these changes
Mar 1, 2024
MaxGekk
requested changes
Mar 2, 2024
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Mar 4, 2024
|
All GAs passed. +1, LGTM. Merging to master. |
ericm-db
added a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
Setting the processorHandle as a part of the statefulProcessor, so that the user doesn't have to explicitly keep track of it, and can instead simply call `getStatefulProcessorHandle` This enhances the usability of the State API Yes, this is an API change. This enhances usability of the StatefulProcessorHandle and the TransformWithState operator. Existing unit tests are sufficient No Closes apache#45359 from ericm-db/handle-context. Authored-by: Eric Marnadi <eric.marnadi@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
### What changes were proposed in this pull request? Setting the processorHandle as a part of the statefulProcessor, so that the user doesn't have to explicitly keep track of it, and can instead simply call `getStatefulProcessorHandle` ### Why are the changes needed? This enhances the usability of the State API ### Does this PR introduce _any_ user-facing change? Yes, this is an API change. This enhances usability of the StatefulProcessorHandle and the TransformWithState operator. ### How was this patch tested? Existing unit tests are sufficient ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45359 from ericm-db/handle-context. Authored-by: Eric Marnadi <eric.marnadi@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Setting the processorHandle as a part of the statefulProcessor, so that the user doesn't have to explicitly keep track of it, and can instead simply call
getStatefulProcessorHandleWhy are the changes needed?
This enhances the usability of the State API
Does this PR introduce any user-facing change?
Yes, this is an API change. This enhances usability of the StatefulProcessorHandle and the TransformWithState operator.
How was this patch tested?
Existing unit tests are sufficient
Was this patch authored or co-authored using generative AI tooling?
No