[SPARK-47266][CONNECT] Make ProtoUtils.abbreviate return the same type as the input
#45369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Mar 4, 2024
|
Merged to master. |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…ype as the input ### What changes were proposed in this pull request? Make `ProtoUtils.abbreviate` return the same type as the input ### Why are the changes needed? existing implementation always return the superclass `Message` (e.g. `proto.Relation` -> `Message`), while this method actually can return the same type (e.g. `proto.Relation` -> `proto.Relation`). ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? updated tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45369 from zhengruifeng/connect_proto_return_type. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
…ype as the input ### What changes were proposed in this pull request? Make `ProtoUtils.abbreviate` return the same type as the input ### Why are the changes needed? existing implementation always return the superclass `Message` (e.g. `proto.Relation` -> `Message`), while this method actually can return the same type (e.g. `proto.Relation` -> `proto.Relation`). ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? updated tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45369 from zhengruifeng/connect_proto_return_type. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
ProtoUtils.abbreviatereturn the same type as the inputWhy are the changes needed?
existing implementation always return the superclass
Message(e.g.proto.Relation->Message),while this method actually can return the same type (e.g.
proto.Relation->proto.Relation).Does this PR introduce any user-facing change?
no
How was this patch tested?
updated tests
Was this patch authored or co-authored using generative AI tooling?
no