Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47281][PYTHON][DOCS] Update the versions.json file for the already released spark version #45386

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Mar 5, 2024

What changes were proposed in this pull request?

The pr aims to update the versions. json file for the already released spark version.

Why are the changes needed?

Make the pyspark document display correctly.

Does this PR introduce any user-facing change?

Yes, only for pyspark docs.

How was this patch tested?

Manually test.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon HyukjinKwon changed the title [SPARK-47281][PYSPARK][DOCS] Update the versions. json file for the already released saprk version [SPARK-47281][PYTHON][DOCS] Update the versions. json file for the already released saprk version Mar 5, 2024
@panbingkun panbingkun changed the title [SPARK-47281][PYTHON][DOCS] Update the versions. json file for the already released saprk version [SPARK-47281][PYTHON][DOCS] Update the versions. json file for the already released spark version Mar 5, 2024
@panbingkun
Copy link
Contributor Author

@panbingkun
Copy link
Contributor Author

For the published document, I will submit another PR to manually update it first.

@panbingkun
Copy link
Contributor Author

panbingkun commented Mar 5, 2024

For the published document, I will submit another PR to manually update it first.

Okay, I checked the spark-website code repository and currently only the spark-3.5.1 version has this feature. Other released versions do not yet have this feature, so there is no need to update the already published documentation.

apache/spark-website#507

@HeartSaVioR
Copy link
Contributor

HeartSaVioR commented Mar 5, 2024

We shouldn't go with this approach before constructing the story to update the released versions of docs. I feel like this is not scalable.

@panbingkun
Copy link
Contributor Author

I have marked this PR on JIRA and it needs to be applied to branch-3.5.1

image

@panbingkun
Copy link
Contributor Author

We shouldn't go with this approach before constructing the story to update the released versions of docs. I feel like this is not scalable.

If this feature is not needed for the time being, I can submit a PR to revert this feature first.

@panbingkun
Copy link
Contributor Author

The PR for removing this feature is here: #45387

@LuciferYang LuciferYang changed the title [SPARK-47281][PYTHON][DOCS] Update the versions. json file for the already released spark version [SPARK-47281][PYTHON][DOCS] Update the versions.json file for the already released spark version Mar 6, 2024
@panbingkun panbingkun marked this pull request as draft March 6, 2024 02:23
@panbingkun panbingkun closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants