[SPARK-47304][SQL][TESTS] Distribute tests from DataFrameSuite to more specific suites
#45392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
DataFrameSuite to more specific suitesDataFrameSuite to more specific suites
MaxGekk
changed the title
DataFrameSuite to more specific suitesDataFrameSuite to more specific suites
cloud-fan
reviewed
Mar 6, 2024
sql/core/src/test/scala/org/apache/spark/sql/DataFrameShowSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 6, 2024
| @@ -365,4 +367,57 @@ class DataFrameToSchemaSuite extends QueryTest with SharedSparkSession { | |||
| errorClass = "NOT_NULL_CONSTRAINT_VIOLATION.MAP_VALUE", | |||
| parameters = Map("columnPath" -> "`map`")) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This test suite is for the df.to API. I feel it's better to put these tests in DataFrameShowSuite, as printSchema is more related to df.show
cloud-fan
reviewed
Mar 6, 2024
|
|
||
| test("SPARK-32761: aggregating multiple distinct CONSTANT columns") { | ||
| checkAnswer(sql("select count(distinct 2), count(distinct 2,3)"), Row(1, 1)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
just for curiosity, what's the runtime of DataFrameAggregateSuite? It has more than 2000 LOC...
There was a problem hiding this comment.
1 min 5 sec on my laptop.
cloud-fan
approved these changes
Mar 6, 2024
|
Merging to master. Thank you, @cloud-fan for review. |
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
…ore specific suites ### What changes were proposed in this pull request? In the PR, I propose to move some tests from `DataFrameSuite` out, and distribute them across more specific tests suites and new one `DataFrameShowSuite`. ### Why are the changes needed? 1. Improve maintainability of `DataFrameSuite` 2. Speed up execution of the test suite. Execution time dropped to < 1min. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test suites. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45392 from MaxGekk/split-DataFrameSuite. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to move some tests from
DataFrameSuiteout, and distribute them across more specific tests suites and new oneDataFrameShowSuite.Why are the changes needed?
DataFrameSuiteDoes this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites.
Was this patch authored or co-authored using generative AI tooling?
No.