SPARK-5747: Fix wordsplitting bugs in make-distribution.sh

[dyross]

The $MVN command variable may have spaces, so when referring to it, must wrap in quotes.

[nchammas]

I'm guessing this is a continuation of #4126.

[dyross]

@nchammas it is related, but #4126 was a fix to a previous break. This change is a fix after this commit: e902dc4

Sorry, I should have specified that in the description.

[nchammas]

@dyross Thank you for fixing this issue. Could you:

• Create a sub-task under SPARK-5747 for make-distribution.sh
• Update the title of this PR to reference the new JIRA issue
• Resolve all other word splitting issues with make-distribution.sh

Totally fine if you just want to fix the call to Maven, but there are a few other problematic places in this script.

For example:

• sub-shell output may contain spaces
• $RPM_JAVA_HOME may contain spaces

[nchammas]

FWIW, this patch LGTM as-is.

[srowen]

Rather than add yet more JIRAs, let's just make this part of the SPARK-5747 umbrella. We may have two commits, sure. Putting the JIRA in the title, and perhaps addressing a few more instances of this in the script, would be great.

@pwendell quick check -- if we make a fix like this, how far back does it get back-ported? 1.2 or further?

[dyross]

I've updated the commit wording and fixed a few more instances, as requested. The script seems to execute fine in our build system, but I am not 100% sure about all the edge cases.

[nchammas]

I think we need to quote the subshell, since its output may contain spaces.

RPM_JAVA_HOME="$(rpm -E %java_home 2>/dev/null)"

[dyross]

Done.

[nchammas]

Thanks for the updates @dyross! One minor comment and I think this is good to go.

[nchammas]

This patch LGTM.

[dyross]

Thanks for the review, @nchammas.

[srowen]

ok to test

[SparkQA]

Test build #27381 has finished for PR 4540 at commit 5a41596.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

Merging into master 1.3 thanks. There were significant merge conflicts for branch-1.2 so @dyross it would be good if you could open this PR against that branch too.