[SPARK-47299][PYTHON][DOCS] Use the same versions.json in the dropdown of different versions of PySpark documents
#45400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own of different versions of PySpark documents
HeartSaVioR
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
+1
@panbingkun Could you please remove the versions.json in pyspark docs as well to be not confused?
|
(BTW sorry for visiting this too lately. Was very busy with other stuffs.) |
Done @HeartSaVioR Thank you |
|
Thanks! Merging to master/3.5. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Apr 8, 2024
…own of different versions of PySpark documents ### What changes were proposed in this pull request? The pr aims to use the same `versions.json` in the dropdown of `different versions` of PySpark documents. ### Why are the changes needed? As discussed in the email group, using this approach can avoid `maintenance difficulties` and `inconsistencies` that may arise when `multi active release version lines` are released in the future. <img width="798" alt="image" src="https://github.com/apache/spark/assets/15246973/8a08a4fe-e1fb-4334-a3f9-c6dffb01cbd6"> ### Does this PR introduce _any_ user-facing change? Yes, only for pyspark docs. ### How was this patch tested? - Manually test. - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45400 from panbingkun/SPARK-47299. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit b299b2b) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to use the same
versions.jsonin the dropdown ofdifferent versionsof PySpark documents.Why are the changes needed?
As discussed in the email group, using this approach can avoid
maintenance difficultiesandinconsistenciesthat may arise whenmulti active release version linesare released in the future.Does this PR introduce any user-facing change?
Yes, only for pyspark docs.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.