[SPARK-47035][SS][CONNECT][FOLLOWUP] Additional protobuf change to client side listener #45444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundprinzip
approved these changes
Mar 9, 2024
HyukjinKwon
approved these changes
Mar 11, 2024
|
Merged to master. |
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
…ient side listener ### What changes were proposed in this pull request? Followup of previous protocol change apache#45091. Add the request proto `Command` and response proto message to `ExecutePlanResponse` ### Why are the changes needed? Continuation of client side listener for spark connect ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Will be tested in subsequent PR, the proto change itself doesn't do any harm ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45444 from WweiL/SPARK-47035-protocol-followup. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…ient side listener ### What changes were proposed in this pull request? Followup of previous protocol change apache#45091. Add the request proto `Command` and response proto message to `ExecutePlanResponse` ### Why are the changes needed? Continuation of client side listener for spark connect ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Will be tested in subsequent PR, the proto change itself doesn't do any harm ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45444 from WweiL/SPARK-47035-protocol-followup. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
WweiL
added a commit
to WweiL/oss-spark
that referenced
this pull request
May 2, 2024
…ient side listener Followup of previous protocol change apache#45091. Add the request proto `Command` and response proto message to `ExecutePlanResponse` Continuation of client side listener for spark connect No Will be tested in subsequent PR, the proto change itself doesn't do any harm No Closes apache#45444 from WweiL/SPARK-47035-protocol-followup. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of previous protocol change #45091. Add the request proto
Commandand response proto message toExecutePlanResponseWhy are the changes needed?
Continuation of client side listener for spark connect
Does this PR introduce any user-facing change?
No
How was this patch tested?
Will be tested in subsequent PR, the proto change itself doesn't do any harm
Was this patch authored or co-authored using generative AI tooling?
No