Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47334][SQL] Make withColumnRenamed reuse the implementation of withColumnsRenamed #45450

Closed

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Make withColumnRenamed reuse the implementation of withColumnsRenamed

Why are the changes needed?

to avoid any divergence in the future

Does this PR introduce any user-facing change?

no

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Mar 9, 2024
@HyukjinKwon
Copy link
Member

Merged to master.

@zhengruifeng zhengruifeng deleted the with_rename_consistent branch March 11, 2024 00:59
@zhengruifeng
Copy link
Contributor Author

thanks @HyukjinKwon for reviews!

jpcorreia99 pushed a commit to jpcorreia99/spark that referenced this pull request Mar 12, 2024
…of `withColumnsRenamed`

### What changes were proposed in this pull request?
Make `withColumnRenamed` reuse the implementation of `withColumnsRenamed`

### Why are the changes needed?
to avoid any divergence in the future

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
ci

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#45450 from zhengruifeng/with_rename_consistent.

Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
…of `withColumnsRenamed`

### What changes were proposed in this pull request?
Make `withColumnRenamed` reuse the implementation of `withColumnsRenamed`

### Why are the changes needed?
to avoid any divergence in the future

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
ci

### Was this patch authored or co-authored using generative AI tooling?
no

Closes apache#45450 from zhengruifeng/with_rename_consistent.

Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants