[SPARK-45827][SQL] Add variant singleton type for Java #45455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Mar 11, 2024
HyukjinKwon
changed the title
HyukjinKwon
changed the title
MaxGekk
approved these changes
Mar 11, 2024
|
The test failure is not related to the changes: Run / Run Docker integration tests +1, LGTM. Merging to master. |
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
### What changes were proposed in this pull request? Adds the Variant singleton ### Why are the changes needed? Dependent projects (i.e. Delta kernel) require access to this singleton ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45455 from richardc-db/add_variant_singleton_type. Authored-by: Richard Chen <r.chen@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? Adds the Variant singleton ### Why are the changes needed? Dependent projects (i.e. Delta kernel) require access to this singleton ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45455 from richardc-db/add_variant_singleton_type. Authored-by: Richard Chen <r.chen@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the Variant singleton
Why are the changes needed?
Dependent projects (i.e. Delta kernel) require access to this singleton
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no