Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Minor English fixes #45461

Closed
wants to merge 2 commits into from

Conversation

nchammas
Copy link
Contributor

What changes were proposed in this pull request?

Minor English grammar and wording fixes.

Why are the changes needed?

They're not strictly needed, but give the project a tiny bit more polish.

Does this PR introduce any user-facing change?

Yes, some user-facing errors have been tweaked.

How was this patch tested?

No testing beyond CI.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member

I think the test failure is related:

[info] - Error classes match with document *** FAILED *** (145 milliseconds)
[info]   "...one of the DataFrame[s] but Spark is unable..." did not equal "...one of the DataFrame[] but Spark is unable..." The error class document is not up to date. Please regenerate it by running `SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "core/testOnly *SparkThrowableSuite -- -t \"Error classes match with document\""` (SparkThrowableSuite.scala:357)
[info]   Analysis:
[info]   "...one of the DataFrame[s] but Spark is unable..." -> "...one of the DataFrame[] but Spark is unable..."
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info]   at org.apache.spark.SparkThrowableSuite.$anonfun$new$22(SparkThrowableSuite.scala:357)
[info]   at org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
[info]   at org.scalatest.concurrent.TimeLimits$.failAfterImpl(TimeLimits.scala:282)
[info]   at org.scalatest.concurrent.TimeLimits.failAfter(TimeLimits.scala:231)
[info]   at org.scalatest.concurrent.TimeLimits.failAfter$(TimeLimits.scala:230)
[info]   at org.apache.spark.SparkFunSuite.failAfter(SparkFunSuite.scala:69)
[info]   at org.apache.spark.SparkFunSuite.$anonfun$test$2(SparkFunSuite.scala:155)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)

@xinrong-meng
Copy link
Member

LGTM after fixing the test, thanks!

@github-actions github-actions bot added the DOCS label Mar 12, 2024
@nchammas
Copy link
Contributor Author

Ah, the test failure is due to the generated error documentation that is checked in to git.

#44971 will eliminate this kind of maintenance headache. (Also, look at that diff count. Just beautiful.)

That PR is unfortunately blocked by the pending discussion in SPARK-46810.

@zhengruifeng
Copy link
Contributor

thanks, merged to master

@nchammas nchammas deleted the minor-wording-tweaks branch March 12, 2024 16:45
jpcorreia99 pushed a commit to jpcorreia99/spark that referenced this pull request Mar 12, 2024
### What changes were proposed in this pull request?

Minor English grammar and wording fixes.

### Why are the changes needed?

They're not strictly needed, but give the project a tiny bit more polish.

### Does this PR introduce _any_ user-facing change?

Yes, some user-facing errors have been tweaked.

### How was this patch tested?

No testing beyond CI.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45461 from nchammas/minor-wording-tweaks.

Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
### What changes were proposed in this pull request?

Minor English grammar and wording fixes.

### Why are the changes needed?

They're not strictly needed, but give the project a tiny bit more polish.

### Does this PR introduce _any_ user-facing change?

Yes, some user-facing errors have been tweaked.

### How was this patch tested?

No testing beyond CI.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45461 from nchammas/minor-wording-tweaks.

Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants