[SPARK-45827][SQL][FOLLOWUP] Fix for collation #45463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Mar 11, 2024
dbatomic
approved these changes
Mar 11, 2024
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Mar 11, 2024
|
Thank you, @cashmand and all. Merged to master. |
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
### What changes were proposed in this pull request? apache#45409 created a default allow-list of types for data sources. The intent was to only prevent creation of the two types that had already been prevented elsewhere in code, but the match expression matched `StringType`, which is an object representing the default collation, instead of the `StringType` class, which represents any collation. This PR fixes the issue. ### Why are the changes needed? Without it, the previous PR would be a breaking change for data sources that write StringType with a non-default collation. ### Does this PR introduce _any_ user-facing change? It reverts the previous unintentional user-facing change. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45463 from cashmand/SPARK-45827-followup. Authored-by: cashmand <david.cashman@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? apache#45409 created a default allow-list of types for data sources. The intent was to only prevent creation of the two types that had already been prevented elsewhere in code, but the match expression matched `StringType`, which is an object representing the default collation, instead of the `StringType` class, which represents any collation. This PR fixes the issue. ### Why are the changes needed? Without it, the previous PR would be a breaking change for data sources that write StringType with a non-default collation. ### Does this PR introduce _any_ user-facing change? It reverts the previous unintentional user-facing change. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45463 from cashmand/SPARK-45827-followup. Authored-by: cashmand <david.cashman@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#45409 created a default allow-list of types for data sources. The intent was to only prevent creation of the two types that had already been prevented elsewhere in code, but the match expression matched
StringType, which is an object representing the default collation, instead of theStringTypeclass, which represents any collation. This PR fixes the issue.Why are the changes needed?
Without it, the previous PR would be a breaking change for data sources that write StringType with a non-default collation.
Does this PR introduce any user-facing change?
It reverts the previous unintentional user-facing change.
How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.