-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-47363][SS] Initial State without state reader implementation for State API v2. #45467
Changes from 25 commits
190bdbb
ad2a3bd
bd9d2f9
5587b08
8a863a1
4aebe30
fd31d2b
c8cf3c3
bd5d908
e2b1875
0e5e997
7e56085
6465521
9f18601
20bc216
d0abba7
ce51342
827cef3
7fa7adb
e25a352
c659d17
4424c00
40465b6
d91817a
b3394d0
695a02b
1ca648f
88d8de7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,11 +268,13 @@ class IncrementalExecution( | |
) | ||
|
||
case t: TransformWithStateExec => | ||
val hasInitialState = (isFirstBatch && t.hasInitialState) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want to allow adding state in the middle of the query lifecycle. Here This should follow the above logic we did for FlatMapGroupsWithStateExec, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please let me know if this is a different functionality than we had in flatMapGroupsWithState. |
||
t.copy( | ||
stateInfo = Some(nextStatefulOperationStateInfo()), | ||
batchTimestampMs = Some(offsetSeqMetadata.batchTimestampMs), | ||
eventTimeWatermarkForLateEvents = None, | ||
eventTimeWatermarkForEviction = None | ||
eventTimeWatermarkForEviction = None, | ||
hasInitialState = hasInitialState | ||
) | ||
|
||
case m: FlatMapGroupsInPandasWithStateExec => | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we follow the practice we did in flatMapGroupsWithState for safeness sake?
initialState.queryExecution.analyzed