[SPARK-47373][SQL] Match FileSourceScanLike to get metadata instead of FileSourceScanExec #45491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f FileSourceScanExec
HyukjinKwon
approved these changes
Mar 13, 2024
yaooqinn
approved these changes
Mar 13, 2024
dongjoon-hyun
approved these changes
Mar 13, 2024
|
Thank you, @zwangsheng and all! |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…f FileSourceScanExec ### What changes were proposed in this pull request? When get Spark Plan info, we should match basic trait `FileSourceScanLike` to get metadata instead of matching subclass `FileSourceScanExec`. So that user-define file scan operators(which extend `FileSourceScanLike`) can be matched. ### Why are the changes needed? Match user-define file scan operators. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exists Unit Test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45491 from zwangsheng/SPARK-47373. Authored-by: zwangsheng <binjieyang@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When get Spark Plan info, we should match basic trait
FileSourceScanLiketo get metadata instead of matchingsubclass
FileSourceScanExec.So that user-define file scan operators(which extend
FileSourceScanLike) can be matched.Why are the changes needed?
Match user-define file scan operators.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists Unit Test
Was this patch authored or co-authored using generative AI tooling?
No