[SPARK-47388][SQL] Pass messageParameters by name to require()
#45511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
messageParameters by name to require()messageParameters by name to require()
cloud-fan
approved these changes
Mar 14, 2024
HyukjinKwon
approved these changes
Mar 14, 2024
|
Merging to master. Thank you, @cloud-fan and @HyukjinKwon for review. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? In the PR, I propose to pass `messageParameters` by name to avoid eager instantiation. ### Why are the changes needed? Passing `messageParameters` by value independently from `requirement` might introduce perf regression. ### Does this PR introduce _any_ user-facing change? No, this is not a part of public API. ### How was this patch tested? By running the affected test suite: ``` $ build/sbt "test:testOnly *QueryCompilationErrorsSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45511 from MaxGekk/fix-SparkException-require. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to pass
messageParametersby name to avoid eager instantiation.Why are the changes needed?
Passing
messageParametersby value independently fromrequirementmight introduce perf regression.Does this PR introduce any user-facing change?
No, this is not a part of public API.
How was this patch tested?
By running the affected test suite:
Was this patch authored or co-authored using generative AI tooling?
No.