[SPARK-47445][CONNECT][SQL] Add new ExplainMode - SilentMode #45542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForVic
changed the title
ForVic
changed the title
robreeves
reviewed
Mar 18, 2024
| @@ -125,6 +125,9 @@ message AnalyzePlanRequest { | |||
|
|
|||
| // Generates a physical plan outline and also node details. | |||
| EXPLAIN_MODE_FORMATTED = 5; | |||
|
|
|||
| // Does not generate any plan when used. | |||
| EXPLAIN_MODE_SILENT = 6; | |||
There was a problem hiding this comment.
nit: Disabled feels more intuitive to me than silent for the naming.
Suggested change
| EXPLAIN_MODE_SILENT = 6; | |
| EXPLAIN_MODE_DISABLED = 6; |
There was a problem hiding this comment.
Are you referring to everywhere, or just here? I'm fine with changing it everywhere, but if that's not the suggestion I think we should keep all references to that mode the same.
ForVic
changed the title
ForVic
force-pushed
the
vsunderl/explain_silent_mode
branch
from
a37d1a6
to
bca2424
Compare
exia70
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Overall LGTM.
Could you please review the two files I put below to see if changes are needed.
spark/python/pyspark/sql/connect/dataframe.py
Line 1914 in c32d278
spark/python/pyspark/errors/error_classes.py
Line 1016 in c32d278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I've added a new ExplainMode, SilentMode, which allows us to use EXPLAIN or .explainString without any output.
Why are the changes needed?
While investigating unit test duration we found that org.apache.spark.sql.execution.QueryExecution.explainString () takes approximately 14% time. This method generates the string representation of the execution plan. The string is often used for logging purposes. This is also called for each AQE job so it can save prod execution time too. While SPARK-44485 does exist to help optimize the prod execution time, the main purpose of this PR is to save time during unit testing.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
A couple new unit tests + existing.
Was this patch authored or co-authored using generative AI tooling?
No