[SPARK-44708][PYTHON] Migrate test_reset_index assert_eq to use assertDataFrameEqual #45629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
|
cc @itholic |
itholic
reviewed
Mar 21, 2024
| @@ -22,6 +22,7 @@ | |||
| from pyspark import pandas as ps | |||
| from pyspark.testing.pandasutils import PandasOnSparkTestCase | |||
| from pyspark.testing.sqlutils import SQLTestUtils | |||
| from pyspark.testing.utils import assertDataFrameEqual | |||
There was a problem hiding this comment.
It is not a very big deal, but I personally recommend to use assert_frame_equal instead of assertDataFrameEqual for comparing Pandas API on Spark objects because assert_frame_equal directly leverage the Pandas testing utils internally so it is more proper to compare the Pandas objects:
from pyspark.pandas.testing import assert_frame_equal
There was a problem hiding this comment.
See #43398 which introduces Pandas-like testing utils FYI.
There was a problem hiding this comment.
Got it. Changed it to assert_frame_equal.
itholic
approved these changes
Mar 22, 2024
HyukjinKwon
approved these changes
Mar 22, 2024
xinrong-meng
approved these changes
Mar 22, 2024
|
LGTM thanks! |
HyukjinKwon
approved these changes
Mar 24, 2024
|
Merged to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…tDataFrameEqual ### What changes were proposed in this pull request? This PR updates the [python/pyspark/pandas/tests/test_sql.py](https://github.com/apache/spark/blob/42e5daddf3ba16ff7d08e82e51cd8924cc56e180/python/pyspark/pandas/tests/indexes/test_reset_index.py#L46) to use the new PySpark test util function, assertDataFrameEqual, introduced in [SPARK-44042](https://issues.apache.org/jira/browse/SPARK-44042). ### Why are the changes needed? Use the new `assertDataFrameEqual` util function across all tests in PySpark ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing Tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45629 from gdhuper/gdhuper/SPARK-44708. Authored-by: Gurpreet Singh <gdhuper@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the python/pyspark/pandas/tests/test_sql.py to use the new PySpark test util function, assertDataFrameEqual, introduced in SPARK-44042.
Why are the changes needed?
Use the new
assertDataFrameEqualutil function across all tests in PySparkDoes this PR introduce any user-facing change?
No
How was this patch tested?
Existing Tests
Was this patch authored or co-authored using generative AI tooling?
No