[SPARK-47533][BUILD] Migrate scalafmt dialect to scala213
#45683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runner.dialect = scala213 | ||
| } | ||
| } | ||
| runner.dialect = scala213 |
There was a problem hiding this comment.
Nice catch. It seems to work. Is it ready, @panbingkun ?
There was a problem hiding this comment.
Yes, I have checked it on local and it is ready!
I have triggered the failed job on GA.
Thank you very much! ❤️
panbingkun
changed the title
scala213
dongjoon-hyun
approved these changes
Mar 24, 2024
|
Merged to master for Apache Spark 4.0.0. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? The pr aims to migrate `scalafmt dialect` from `scala212` to `scala213`. ### Why are the changes needed? In the Spark version `4.0.0`, the version `scala2.12 ` is no longer supported. During our migration from `scala2.12` to `scala2.13`, this should be migrated synchronously. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45683 from panbingkun/scalafmt_dialect. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate
scalafmt dialectfromscala212toscala213.Why are the changes needed?
In the Spark version
4.0.0, the versionscala2.12is no longer supported. During our migration fromscala2.12toscala2.13, this should be migrated synchronously.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.