[SPARK-47623][PYTHON][CONNECT][TESTS] Use QuietTest in parity tests
#45747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Mar 28, 2024
| @@ -184,6 +184,7 @@ def setUpClass(cls): | |||
| .remote(cls.master()) | |||
| .getOrCreate() | |||
| ) | |||
| cls._legacy_sc = PySparkSession._instantiatedSession._sc | |||
There was a problem hiding this comment.
refer to test_connect_basic
spark/python/pyspark/sql/tests/connect/test_connect_basic.py
Lines 66 to 68 in 714feb7
HyukjinKwon
approved these changes
Mar 28, 2024
xinrong-meng
approved these changes
Mar 28, 2024
ueshin
approved these changes
Mar 28, 2024
|
Merged to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? 1, add `def quiet` in both `ReusedPySparkTestCase` and `ReusedConnectTestCase`; 2, replace existing `QuietTest(self.sc)` with `self.quiet()`; 3, remove unnecessary overridden parity tests; ### Why are the changes needed? there are a lot of tests not enabled in parity test due to the usage of `sc` in `with QuietTest(self.sc)`, some of them were break into `def check_` and call the `check_` functions in the parity tests; However, there are still such tests not enabled. This PR aims to enable `QuietTest` within parity tests and make it easier to enable the remaining tests (`def check_` no longer needed). ### Does this PR introduce _any_ user-facing change? no, test only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45747 from zhengruifeng/py_test_sc. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, add
def quietin bothReusedPySparkTestCaseandReusedConnectTestCase;2, replace existing
QuietTest(self.sc)withself.quiet();3, remove unnecessary overridden parity tests;
Why are the changes needed?
there are a lot of tests not enabled in parity test due to the usage of
scinwith QuietTest(self.sc), some of them were break intodef check_and call thecheck_functions in the parity tests;However, there are still such tests not enabled.
This PR aims to enable
QuietTestwithin parity tests and make it easier to enable the remaining tests (def check_no longer needed).Does this PR introduce any user-facing change?
no, test only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no