[SPARK-42846][SQL] Integrate _LEGACY_ERROR_TEMP_2011 into UNEXPECTED_DATA_TYPE #45786
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiuKwok
changed the title
HiuKwok
changed the title
HiuKwok
force-pushed
the
ft-hf-SPARK-42846-rename-error-class-2011
branch
from
ae887c3
to
c9fe72a
Compare
|
@MaxGekk Hi, would you mind having a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to replace _LEGACY_ERROR_TEMP_2011 with UNEXPECTED_DATA_TYPE, as part of the parent initiative of SPARK-37935
Why are the changes needed?
To rename the legacy error class as part of the refactoring effort, and simplify Spark's error handling aspect.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No
I have tried to test
QueryExecutionErrors.typeUnsupportedErroralso. Still, by understanding the SQL module code base better, seem there is no way to do that, as all inferred types generated byinferPartitionColumnValue( )are already covered bycastPartValueToDesiredType( ).Also, I have tried the approach of custom type, but by doing so
castPartValueToDesiredType( )will be skipped.