[SPARK-47726][DOC] Document push-based shuffle metrics #45872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1291,6 +1291,17 @@ These metrics are exposed by Spark executors. | |||
| - shuffleRemoteBytesReadToDisk.count | |||
| - shuffleTotalBytesRead.count | |||
| - shuffleWriteTime.count | |||
| - Metrics related to push-based shuffle: | |||
There was a problem hiding this comment.
Are these always exposed when we don't use push-based shuffle?
There was a problem hiding this comment.
Yes, they are. I understand https://issues.apache.org/jira/browse/SPARK-42203 is supposed to take care of that issue.
There was a problem hiding this comment.
Thanks! I pinged on SPARK-42203. Let's wait for a few days.
|
Sorry for making you wait. It seems that SPARK-42203 will not happen. Let's proceed this first. |
dongjoon-hyun
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
+1, LGTM. Thank you, @LucaCanali .
Merged to master for Apache Spark 4.0.0.
|
Thank you @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds documentation for the push-based shuffle metrics
Why are the changes needed?
The push-based shuffle metrics are currently not documented
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No