[SPARK-47587][SQL] Hive module: Migrate logWarn with variables to structured logging framework #45927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uctured logging framework
panbingkun
changed the title
panbingkun
commented
Apr 11, 2024
| "HiveClient got thrift exception, destroying client and retrying " + | ||
| s"(${retryLimit - numTries} tries remaining)", e) | ||
| log"HiveClient got thrift exception, destroying client and retrying " + | ||
| log"${MDC(RETRY_COUNT, numTries)} times", e) |
There was a problem hiding this comment.
Although there is a slight difference in the meaning expressed in these two places, one is how many times are left and the other is how many times have been retried. In order to be consistent with other parts of Spark, adjustments have been made here
panbingkun
commented
Apr 11, 2024
| catalogProxy.invalidateCachedTable(tableIdentifier) | ||
| None | ||
| } | ||
| } | ||
|
|
||
| private def logWarningUnexpectedFileFormat( |
There was a problem hiding this comment.
Extract a common method
panbingkun
changed the title
gengliangwang
approved these changes
Apr 11, 2024
|
Thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate
logWarningin moduleHivewith variables tostructured logging framework.Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.