[SPARK-47589][SQL]Hive-Thriftserver: Migrate logError with variables to structured logging framework #45936
Conversation
gengliangwang
changed the title
dongjoon-hyun
changed the title
gengliangwang
changed the title
|
Oh, should this be |
|
Just for my knowledge, may I ask why this should be different from the GitHub Action label, @gengliangwang ? 
|
gengliangwang
changed the title
|
@dongjoon-hyun ok, I just changed back to |
|
Oh, I didn't mean it was wrong here. I want to understand the organization of this log migration workitem. :) |
I am trying to split the tasks as per the "project" definition in SBT. For example, we got project Connectors are special. We can have 3 PRs to cover all of them, instead of migration for each connector. There are around 30 migration tasks from https://issues.apache.org/jira/browse/SPARK-47240. The size seems reasonable. It is neither too large nor too small. |
| @@ -142,7 +144,9 @@ private[hive] class SparkExecuteStatementOperation( | |||
| } catch { | |||
| case NonFatal(e) => | |||
| setOperationException(new HiveSQLException(e)) | |||
| logError(s"Error cancelling the query after timeout: $timeout seconds") | |||
| val timeout_ms = timeout * MILLIS_PER_SECOND | |||
There was a problem hiding this comment.
qq, just for my personal understanding: why do we convert second to millisecond here?
|
@dongjoon-hyun @itholic Thanks for the review. Merging to master |
|
+1, LGTM. Thank you! |
What changes were proposed in this pull request?
Migrate logError with variables of Hive-thriftserver module to the structured logging framework.
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No