Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47601][GRAPHX] Graphx: Migrate logs with variables to structured logging framework #45947

Closed
wants to merge 1 commit into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Apr 9, 2024

What changes were proposed in this pull request?

This PR proposes to migrate logs with variables of Graphx module to structured logging framework.

Why are the changes needed?

To improve the existing logging system by migrating into structured logging.

Does this PR introduce any user-facing change?

No API changes, but the SQL catalyst logs will contain MDC(Mapped Diagnostic Context) from now.

How was this patch tested?

Run Scala auto formatting and style check. Also the existing CI should pass.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the GRAPHX label Apr 9, 2024
@itholic itholic changed the title [SPARK-47240][GRAPHX] Graphx: Migrate logs with variables to structured logging framework [SPARK-47601][GRAPHX] Graphx: Migrate logs with variables to structured logging framework Apr 9, 2024
@itholic
Copy link
Contributor Author

itholic commented Apr 9, 2024

@panbingkun
Copy link
Contributor

+1, LGTM

@gengliangwang
Copy link
Member

Thanks, merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants