[SPARK-47784][SS] Merge TTLMode and TimeoutMode into a single TimeMode. #45960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahnib
force-pushed
the
introduce-timeMode
branch
from
32816ea
to
1e819de
Compare
sahnib
force-pushed
the
introduce-timeMode
branch
from
1e819de
to
1189993
Compare
sahnib
changed the title
|
@HeartSaVioR @anishshri-db PTAL. |
anishshri-db
approved these changes
Apr 10, 2024
sahnib
force-pushed
the
introduce-timeMode
branch
from
11ab935
to
2c57f1e
Compare
|
@HeartSaVioR PTAL. |
HeartSaVioR
reviewed
Apr 11, 2024
sql/api/src/main/java/org/apache/spark/sql/streaming/TimeMode.java
Outdated
Show resolved
Hide resolved
sql/api/src/main/java/org/apache/spark/sql/streaming/TimeMode.java
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala
Outdated
Show resolved
Hide resolved
|
The CI failure happened in known flakiness - SparkSessionE2ESuite. |
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR merges the
TimeoutModeandTTLModeparameter fortransformWithStateinto a singleTimeMode. Currently, users need to specify the notion of time (ProcessingTime/EventTime) for timers and ttl separately. This allows users to use a single parameter.We do not expect users to use mix/match EventTime/ProcessingTime for timers and ttl in a single query because it makes hard to reason about the time semantics (when will timer be fired?, when will the state be evicted? etc.). Its simpler to stick to one notion of time throughout timers and ttl.
Why are the changes needed?
Changes are needed to simplify Arbitrary State API
transformWithStateinterface by merging TTLMode/TimeoutMode into a single TimeMode.Does this PR introduce any user-facing change?
Yes, this PR changes the API parameters for
transformWithState.How was this patch tested?
All existing testcases for
transformWithStateAPI pass.Was this patch authored or co-authored using generative AI tooling?
No