[SPARK-47809][SQL] checkExceptionInExpression should check error for each codegen mode
#45997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Apr 11, 2024
| @@ -170,18 +170,15 @@ trait ExpressionEvalHelper extends ScalaCheckDrivenPropertyChecks with PlanTestB | |||
| def checkException(eval: => Unit, testMode: String): Unit = { | |||
| val modes = Seq(CodegenObjectFactoryMode.CODEGEN_ONLY, CodegenObjectFactoryMode.NO_CODEGEN) | |||
| withClue(s"($testMode)") { | |||
| val e = intercept[T] { | |||
| for (fallbackMode <- modes) { | |||
There was a problem hiding this comment.
before, the test passes as long as one codegen mode throws the error.
yaooqinn
approved these changes
Apr 11, 2024
HyukjinKwon
approved these changes
Apr 11, 2024
cloud-fan
changed the title
checkExceptionInExpression should check error for each codegen modecheckExceptionInExpression should check error for each codegen mode
|
Merged to master. Thank you @cloud-fan @dongjoon-hyun @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a bug in the test util
checkExceptionInExpression. It may fail to catch bugs when codegen and non-codegen have different error behaviors. This PR fixes it by checking the error for each codegen mode.This PR also fixes a small error wrapping issue in
SubExprEvaluationRuntime(used by interpreted common subexpression elimination).Why are the changes needed?
bug fix for test utils
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No