Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46812][CONNECT][FOLLOW-UP] Make handleCreateResourceProfileCommand private #45998

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Make handleCreateResourceProfileCommand private

Why are the changes needed?

it should not be exposed to users

Does this PR introduce any user-facing change?

no

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master.

@zhengruifeng
Copy link
Contributor Author

thank you @dongjoon-hyun and @HyukjinKwon

@zhengruifeng zhengruifeng deleted the private_handleCreateResourceProfileCommand branch April 11, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants