[SPARK-47416][SQL] Add new functions to CollationBenchmark #46078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
uros-db
reviewed
Apr 17, 2024
uros-db
reviewed
Apr 17, 2024
sql/core/benchmarks/CollationNonASCIIBenchmark-jdk21-results.txt
Outdated
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
uros-db
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Show resolved
Hide resolved
uros-db
reviewed
Apr 17, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala
Outdated
Show resolved
Hide resolved
uros-db
suggested changes
Apr 17, 2024
vladimirg-db
force-pushed
the
vladimirg-db/add-new-string-functions-to-collation-bencmark
branch
from
f3c2277
to
da3239f
Compare
vladimirg-db
force-pushed
the
vladimirg-db/add-new-string-functions-to-collation-bencmark
branch
from
da3239f
to
b26663e
Compare
uros-db
approved these changes
Apr 17, 2024
cloud-fan
approved these changes
Apr 17, 2024
|
thanks, merging to master! |
vladimirg-db
deleted the
vladimirg-db/add-new-string-functions-to-collation-bencmark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added new benchmarks for contains, startsWith, endsWith prior to improving the implementation for the UTF8_BINARY_LCASE collation.
Why are the changes needed?
To see exact improvements after the implementation of https://issues.apache.org/jira/browse/SPARK-47418
Does this PR introduce any user-facing change?
No
How was this patch tested?
GHA 'Run Benchmarks' ran on this, for both JDK 17 and JDK 21
Was this patch authored or co-authored using generative AI tooling?
No