[SPARK-47596][DSTREAMS] Streaming: Migrate logWarn with variables to structured logging framework #46079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structured logging framework
panbingkun
changed the title
panbingkun
commented
Apr 18, 2024
| logWarning(s"isTimeValid called with $time whereas the last valid time " + | ||
| s"is $lastValidTime") | ||
| logWarning(log"isTimeValid called with ${MDC(TIME, time)} whereas the last valid time " + | ||
| log"is ${MDC(LAST_VALID_TIME, lastValidTime)}") |
There was a problem hiding this comment.
Their types are Time, so the output time units are milliseconds
panbingkun
commented
Apr 18, 2024
| @@ -247,7 +247,8 @@ private[streaming] class ReceivedBlockTracker( | |||
| true | |||
| } catch { | |||
| case NonFatal(e) => | |||
| logWarning(s"Exception thrown while writing record: $record to the WriteAheadLog.", e) | |||
| logWarning(log"Exception thrown while writing record: " + | |||
| log"${MDC(RECEIVED_BLOCK_TRACKER_LOG_EVENT, record)} to the WriteAheadLog.", e) | |||
There was a problem hiding this comment.
I'm not sure if it's called RECORD, maybe it's more general.
There was a problem hiding this comment.
Using the class name RECEIVED_BLOCK_TRACKER_LOG_EVENT is also fine
panbingkun
commented
Apr 18, 2024
| @@ -884,14 +885,16 @@ abstract class DStream[T: ClassTag] ( | |||
| val alignedToTime = if ((toTime - zeroTime).isMultipleOf(slideDuration)) { | |||
| toTime | |||
| } else { | |||
| logWarning(s"toTime ($toTime) is not a multiple of slideDuration ($slideDuration)") | |||
| logWarning(log"toTime (${MDC(TO_TIME, toTime)}) is not a multiple of slideDuration " + | |||
| log"(${MDC(SLIDE_DURATION, slideDuration)})") | |||
There was a problem hiding this comment.
The output time units are milliseconds.
panbingkun
changed the title
gengliangwang
approved these changes
Apr 19, 2024
|
@panbingkun Thanks again for the works! Merging to master. |
|
Structured Streaming supports writing Spark SQL and using SQL to write stream processing logic. Is this possible, similar to the syntax of Flink. SQL can satisfy the flow processing process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate
logWarningin moduleStreamingwith variables tostructured logging framework.Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.