[SPARK-47921][CONNECT] Fix ExecuteJobTag creation in ExecuteHolder

[allisonwang-db]

What changes were proposed in this pull request?

This PR fixes a bug in the ExecuteJobTag creation in ExecuteHolder. The sessionId and userId are reversed.

spark/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala

Lines 296 to 299 in 8aa8ad6

	object ExecuteJobTag {
	private val prefix = "SparkConnect_OperationTag"
	def apply(sessionId: String, userId: String, operationId: String): String = {

Why are the changes needed?

To fix a bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing test

Was this patch authored or co-authored using generative AI tooling?

No

[allisonwang-db]

cc @jasonli-db @HyukjinKwon

[ueshin]

We may want to rather fix the arguments of apply function to be consistent with the usage of them and with the other similar functions:

spark/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala

Lines 296 to 304 in 2a64b70

	object ExecuteJobTag {
	private val prefix = "SparkConnect_OperationTag"
	def apply(sessionId: String, userId: String, operationId: String): String = {
	s"${prefix}_" +
	s"User_${userId}_" +
	s"Session_${sessionId}_" +
	s"Operation_${operationId}"
	}

spark/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala

Lines 312 to 321 in 2a64b70

	object ExecuteSessionTag {
	private val prefix = "SparkConnect_SessionTag"
	def apply(userId: String, sessionId: String, tag: String): String = {
	ProtoUtils.throwIfInvalidTag(tag)
	s"${prefix}_" +
	s"User_${userId}_" +
	s"Session_${sessionId}_" +
	s"Tag_${tag}"
	}

[ueshin]

Also cc @gengliangwang @juliuszsompolski

[gengliangwang]

From the code changes, there does seem to be a bug. All the callers are using the correct order. This PR seems just to unify the usages for such functions.

[ueshin]

The original fix is dd6636b.
I'm fine with it too, but I asked #46140 (comment) because I worried the inconsistency with the similar API.

[juliuszsompolski]

LGTM, thanks for spotting this.

[ueshin]

Thanks! merging to master/3.5.