[SPARK-47600][CORE] MLLib: Migrate logInfo with variables to structured logging framework #46151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeotuan
commented
Apr 22, 2024
| @@ -550,14 +553,15 @@ class KMeans @Since("1.5.0") ( | |||
| blocks.unpersist() | |||
|
|
|||
| val iterationTimeInSeconds = (System.nanoTime() - iterationStartTime) / 1e9 | |||
| instr.logInfo(f"Iterations took $iterationTimeInSeconds%.3f seconds.") | |||
| instr.logInfo(log"Iterations took ${MDC(TIME_UNITS, iterationTimeInSeconds%.3f)} seconds.") | |||
There was a problem hiding this comment.
Note: As per #45903, we are using ms for all the time related context
| logInfo(s"Stage class: $className") | ||
| logInfo(s"Stage uid: ${stage.uid}") | ||
| logInfo(log"Stage class: ${MDC(CLASS_NAME, className)}") | ||
| logInfo(log"Stage uid: ${MDC(STAGE_ID, stage.uid)}") |
There was a problem hiding this comment.
Suggested change
| logInfo(log"Stage uid: ${MDC(STAGE_ID, stage.uid)}") | |
| logInfo(log"Stage uid: ${MDC(PIPELINE_STAGE_UID, stage.uid)}") |
| @@ -253,6 +254,13 @@ private[spark] class OptionalInstrumentation private( | |||
| } | |||
| } | |||
|
|
|||
| override def logInfo(logEntry: LogEntry): Unit = { | |||
There was a problem hiding this comment.
This is so that classes that use the OptionalInstrumentation for logging such as WeightedLeastSquares, CrossValidator can also log MessageWithContext. Else I will get Type Mismatched String => MessageWithContext
| } else { | ||
| logInfo(s"KMeans converged in $iteration iterations.") | ||
| logInfo(log"KMeans converged in " + | ||
| log"${MDC(NUM_ITERATIONS, iteration)} iterations.") |
There was a problem hiding this comment.
nit: can we merge into one line?
|
@zeotuan Thanks for the work! LGTM overall except for some minor comments. |
gengliangwang
approved these changes
Apr 23, 2024
|
Thanks, merging to master |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ed logging framework The PR aims to migrate `logInfo` in module MLLib with variables to structured logging framework. ### Why are the changes needed? To enhance Apache Spark's logging system by implementing structured logging. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46151 from zeotuan/mllibInfo. Lead-authored-by: Tuan Pham <Tuan.Pham@wisetechglobal.com> Co-authored-by: zeotuan <zeotuan@gmailo.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to migrate
logInfoin module MLLib with variables to structured logging framework.Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.