[SPARK-47934] [CORE] Ensure trailing slashes in HistoryServer URL redirections
#46157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
HistoryServer URL redirections
dongjoon-hyun
approved these changes
May 1, 2024
|
Welcome to the Apache Spark community, @huangzhir . This will be a part of Apache Spark 4.0.0. You can check it next Monday's |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…directions ### What changes were proposed in this pull request? This PR addresses the issue outlined in JIRA ticket [SPARK-47934](https://issues.apache.org/jira/browse/SPARK-47934), where inconsistent application of trailing slashes in URL redirections within the Spark's history web UI was leading to unnecessary HTTP redirects by Jetty. This inefficiency caused increased load times and reduced the UI's performance. ### Why are the changes needed? to fix [SPARK-47934](https://issues.apache.org/jira/browse/SPARK-47934) ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? This patch was tested with an added unit test method in the HistoryServerSuite that verifies correct redirection behavior for different attempt IDs. ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46157 from huangzhir/spark-history-fix-url-redirect-slash. Authored-by: huangzhir <306824224@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses the issue outlined in JIRA ticket SPARK-47934, where inconsistent application of trailing slashes in URL redirections within the Spark's history web UI was leading to unnecessary HTTP redirects by Jetty. This inefficiency caused increased load times and reduced the UI's performance.
Why are the changes needed?
to fix SPARK-47934
Does this PR introduce any user-facing change?
no
How was this patch tested?
This patch was tested with an added unit test method in the HistoryServerSuite that verifies correct redirection behavior for different attempt IDs.
Was this patch authored or co-authored using generative AI tooling?
no