[SPARK-47418][SQL] Add hand-crafted implementations for lowercase unicode-aware contains, startsWith and endsWith and optimize UTF8_BINARY_LCASE #46181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code-aware contains, startsWith and endsWith and optimize UTF8_BINARY_LCASE
cloud-fan
approved these changes
Apr 23, 2024
|
Re-running the benchmarks on GHA for the new implementation proposed by @cloud-fan here and after that I will merge the changes. |
uros-db
approved these changes
Apr 23, 2024
|
thanks, merging to master! |
vladimirg-db
deleted the
vladimirg-db/add-hand-crafted-string-function-implementations-for-utf8-binary-lcase-collations
branch
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…code-aware contains, startsWith and endsWith and optimize UTF8_BINARY_LCASE ### What changes were proposed in this pull request? Added hand-crafted implementations of unicode-aware lower-case `contains`, `startsWith`, `endsWith` to optimize UTF8_BINARY_LCASE for ASCII-only strings. ### Why are the changes needed? `UTF8String.toLowerCase()`, which is used for the aforementioned collation-aware functions, has an optimization for full-ascii strings, but still always allocates a new object. In this PR I introduced loop-based implementations, which fall-back to `toLowerCase()` in case they meet a non-asci character. ### Does this PR introduce _any_ user-facing change? No, these functions should behave exactly as: - `lhs.containsInLowerCase(rhs)` == `lhs.toLowerCase().contains(rhs.toLowerCase())` - `lhs.startsWithInLowerCase(rhs)` == `lhs.toLowerCase().startsWith(rhs.toLowerCase())` - `lhs.endsWithInLowerCase(rhs)` == `lhs.toLowerCase().endsWith(rhs.toLowerCase())` ### How was this patch tested? Added new test cases to `org.apache.spark.unsafe.types.CollationSupportSuite` and `org.apache.spark.unsafe.types.UTF8StringSuite`, including several unicode lowercase specific. Also I've run `CollationBenchmark` on GHA for JDK 17 and JDK 21 and have updated the data. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46181 from vladimirg-db/vladimirg-db/add-hand-crafted-string-function-implementations-for-utf8-binary-lcase-collations. Authored-by: Vladimir Golubev <vladimir.golubev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added hand-crafted implementations of unicode-aware lower-case
contains,startsWith,endsWithto optimize UTF8_BINARY_LCASE for ASCII-only strings.Why are the changes needed?
UTF8String.toLowerCase(), which is used for the aforementioned collation-aware functions, has an optimization for full-ascii strings, but still always allocates a new object. In this PR I introduced loop-based implementations, which fall-back totoLowerCase()in case they meet a non-asci character.Does this PR introduce any user-facing change?
No, these functions should behave exactly as:
lhs.containsInLowerCase(rhs)==lhs.toLowerCase().contains(rhs.toLowerCase())lhs.startsWithInLowerCase(rhs)==lhs.toLowerCase().startsWith(rhs.toLowerCase())lhs.endsWithInLowerCase(rhs)==lhs.toLowerCase().endsWith(rhs.toLowerCase())How was this patch tested?
Added new test cases to
org.apache.spark.unsafe.types.CollationSupportSuiteandorg.apache.spark.unsafe.types.UTF8StringSuite, including several unicode lowercase specific. Also I've runCollationBenchmarkon GHA for JDK 17 and JDK 21 and have updated the data.Was this patch authored or co-authored using generative AI tooling?
No